question about arch/ia64/kernel/iosapic.c

[Julia Lawall <julia@xxxxxxx>]

I have the impression that ioremap should not be called with locks held.  
Is this the case?  If so, what should be done in the following code (from 
the function iosapic_init):

        spin_lock_irqsave(&iosapic_lock, flags);
        index = find_iosapic(gsi_base);
        if (index >= 0) {
                spin_unlock_irqrestore(&iosapic_lock, flags);
                return -EBUSY;
        }

        addr = ioremap(phys_addr, 0);
        if (addr == NULL) {
                spin_unlock_irqrestore(&iosapic_lock, flags);
                return -ENOMEM;
        }

thanks,
julia
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html