* Christoph Lameter <cl@xxxxxxxxxxxxxxxxxxxx>: > On Tue, 19 Jan 2010, Alex Chiang wrote: > > > Well, making progress (maybe?). > > Yes I think this is the fix. > > > Now we're hitting a BUG_ON(). > > Thats a kfree of an object not allocated with a slab allocator. > Recovery is easy in such a case: Dont free the object. I don't get it. static int sr_probe(struct device *dev) { /* ... */ cd = kzalloc(sizeof(*cd), GFP_KERNEL); if (!cd) goto fail; /* ... */ fail_put: put_disk(disk); fail_free: kfree(cd); } The kfree() is balanced with kzalloc(). Unless the stack trace is lying to us? /ac -- To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
![]() |