2010/1/14 Émeric Maschino <emeric.maschino@xxxxxxxxx>:
> 2010/1/14 Dave Airlie <airlied@xxxxxxxxxx>:
>> If I had to guess I'd go with
>>
>> b674137755bbe2750f997a2a1264db3cdf8abcb3
>>
>> But maybe a bisect would be more definite.
>
> OK, git bisect pending.
git bisect complete. Here's the result:
f1a2a9b6189f9f5c27672d4d32fec9492c6486b2 is the first bad commit
commit f1a2a9b6189f9f5c27672d4d32fec9492c6486b2
Author: David Miller <davem@xxxxxxxxxxxxx>
Date: Wed Feb 18 15:41:02 2009 -0800
drm: Preserve SHMLBA bits in hash key for _DRM_SHM mappings.
Platforms such as sparc64 have D-cache aliasing issues. We
cannot allow virtual mappings in different contexts to be such
that two cache lines can be loaded for the same backing data.
Updates to one cache line won't be seen by accesses to the other
cache line.
Code in sparc64 and other architectures solve this problem by
making sure that all userland mappings of MAP_SHARED objects have
the same virtual address base. They implement this by keying
off of the page offset, and using that to choose a suitably
consistent virtual address for mmap() requests.
Making things even worse, getting this wrong on sparc64 can result
in hangs during DRM lock acquisition. This is because, at least on
UltraSPARC-III, normal loads consult the D-cache but atomics such
as 'cas' (which is what cmpxchg() is implement using) only consult
the L2 cache. So if a D-cache alias is inserted, the load can
see different data than the atomic, and we'll loop forever because
the atomic compare-and-exchange will never complete successfully.
So to make this all work properly, we need to make sure that the
hash address computed by drm_map_handle() preserves the SHMLBA
relevant bits, and that's what this patch does for _DRM_SHM mappings.
As a historical note, many years ago this bug didn't exist because we
used to just use the low 32-bits of the address as the hash and just
hope for the best. This preserved the SHMLBA bits properly. But when
the hashtab code was added to DRM, this was no longer the case.
Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
Signed-off-by: Dave Airlie <airlied@xxxxxxxxxx>
:040000 040000 ee229f793d981e8991d34826e0ddbc18e4cd9531
f39f75d780bbb1bab844a755886ae81601d9fac5 M drivers
And here are the diffs:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=f1a2a9b6189f9f5c27672d4d32fec9492c6486b2
Should I try to simply revert this patch and see if the "interesting
behaviour" is gone? Will it work with actual 2.6.33 kernel
architecture?
Émeric
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
|