Re: [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, bitmap_find_next_zero_area
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: akinobu.mita@xxxxxxxxx
- Subject: Re: [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, bitmap_find_next_zero_area
- From: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx>
- Date: Sat, 17 Oct 2009 22:43:02 +0900
- Cc: akpm@xxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, fujita.tomonori@xxxxxxxxxxxxx, davem@xxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, benh@xxxxxxxxxxxxxxxxxxx, paulus@xxxxxxxxx, linuxppc-dev@xxxxxxxxxx, tglx@xxxxxxxxxxxxx, mingo@xxxxxxxxxx, hpa@xxxxxxxxx, x86@xxxxxxxxxx, gregkh@xxxxxxx, LW@xxxxxxxxxxxxxxxxxxx, linux-usb@xxxxxxxxxxxxxxx, rolandd@xxxxxxxxx, yevgenyp@xxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, tony.luck@xxxxxxxxx, fenghua.yu@xxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-altix@xxxxxxx
- In-reply-to: <20091013091017.GA18431@xxxxxxxxxxxxxxxxxxxxx>
- List-id: <linux-ia64.vger.kernel.org>
- References: <20091009164100.85a36188.akpm@xxxxxxxxxxxxxxxxxxxx> <20091013021818.GA3898@xxxxxxxxxxxxxxxxxxxxx> <20091013091017.GA18431@xxxxxxxxxxxxxxxxxxxxx>
On Tue, 13 Oct 2009 18:10:17 +0900
Akinobu Mita <akinobu.mita@xxxxxxxxx> wrote:
> My user space testing exposed off-by-one error find_next_zero_area
> in iommu-helper. Some zero area cannot be found by this bug.
>
> Subject: [PATCH] Fix off-by-one error in find_next_zero_area
>
> Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx>
> ---
> lib/iommu-helper.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/lib/iommu-helper.c b/lib/iommu-helper.c
> index 75dbda0..afc58bc 100644
> --- a/lib/iommu-helper.c
> +++ b/lib/iommu-helper.c
> @@ -19,7 +19,7 @@ again:
> index = (index + align_mask) & ~align_mask;
>
> end = index + nr;
> - if (end >= size)
> + if (end > size)
I think that this is intentional; the last byte of the limit doesn't
work.
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]