RE: ticket spinlocks and sizeof(struct dentry)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Just to let you know you may have turned sizeof(struct dentry) into
> something nasty with 64 bit spinlocks (like 200 bytes) which would
> mean a significant number (~half?) of dentries will cover 3 cachelines
> instead of 2.

Thanks for the heads-up ... Linus also pointed out this downside of
the current implementation.  IA64 uses 128 byte cache lines ... so your
calculation of how many we use for a dentry is off (we move from
exactly 1.5 cache lines to 1.5625 cache lines).  But this sucks too
because now the cache-line boundaries are scattered in different
places in different dentry instances, so all your careful work to
put stuff that is used together into the same cache line is randomly
broken on some dentry instances.

> If I'm nost mistaken, this would probably be worth correcting.

I'm working on it.

-Tony

--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [Sparc Linux]     [DCCP]     [Linux ARM]     [Yosemite News]     [Linux SCSI]     [Linux x86_64]     [Linux for Ham Radio]

  Powered by Linux