Christoph Lameter wrote: > On Tue, 22 Sep 2009, Tejun Heo wrote: > >> const unsigned long vmalloc_end = vmalloc_end & ~(align - 1); >> >> Rename local variables vmalloc_start and vmalloc_end to vm_start and >> vm_end to avoid the collision. > > Could you keep vmalloc_end and vmalloc_start? vm_start and vm_end may led > to misinterpretations as start and end of the memory area covered by the > VM. Hmmm... yeah, the right thing to do would be either let ia64 use VMALLOC_END directly as variable name or let it alias an unlikely symbol like ____vmalloc_end as macro which ends up expanding to a seemingly normal symbol like vmalloc_end is just rude. I'll change ia64 part. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|