When compiling drm_cache.c on ia64, gcc reports undefined drm_clflush_ipi_handler() error. The problem is because drm_cache_ipi_handler is a typo. One straightforward fix is changing drm_cache_ipi_handler to drm_clflush_ipi_handler. But since drm_clflush_ipi_handler() does nothing on non-x86 platforms and ipi handling is costly, it would be better to just do nothing on non-x86 platforms and remove drm_clflush_ipi_handler() for those platforms. Signed-off-by: Fenghua Yu <fenghua.yu@xxxxxxxxx> --- The issue was introduced by commit c9c97b8c75019814d8c007059bc827bb475be917 in linux-next. drm_cache.c | 7 ------- 1 files changed, 7 deletions(-) diff --git a/drivers/gpu/drm/drm_cache.c b/drivers/gpu/drm/drm_cache.c index 3a5575e..8054a5c 100644 --- a/drivers/gpu/drm/drm_cache.c +++ b/drivers/gpu/drm/drm_cache.c @@ -62,10 +62,6 @@ drm_clflush_ipi_handler(void *null) { wbinvd(); } -#elif !defined(__powerpc__) -static void drm_cache_ipi_handler(void *dummy) -{ -} #endif void drm_clflush_pages(struct page *pages[], unsigned long num_pages) @@ -94,9 +90,6 @@ drm_clflush_pages(struct page *pages[], unsigned long num_pages) (unsigned long)page_virtual + PAGE_SIZE); kunmap_atomic(page_virtual, KM_USER0); } -#else - if (on_each_cpu(drm_clflush_ipi_handler, NULL, 1) != 0) - printk(KERN_ERR "Timed out waiting for drm cache flush\n"); #endif } EXPORT_SYMBOL(drm_clflush_pages); -- To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
![]() |