> >As allocation and initialization are done by the arch code, all that >setup_per_cpu_areas() needs to do is communicating the determined >layout to the percpu allocator. This patch implements >setup_per_cpu_areas() for both contig and discontig memory models and >drops HAVE_LEGACY_PER_CPU_AREA. > >NOT_SIGNED_OFF_YET >Cc: Tony Luck <tony.luck@xxxxxxxxx> >Cc: Fenghua Yu <fenghua.yu@xxxxxxxxx> >--- >I don't have access to an ia64 machine so I could only test with ski. >With sim_defconfig, it boots but I didn't have any userland. >discontig configuration builds fine but I couldn't test it. > >Can you guys please verify this patch? > >This patch is available in the following git tree. > > git://git.kernel.org/pub/scm/linux/kernel/git/tj/percpu.git review-ia64 > >Thanks. > Is this patch against the latest linux-next? It's applied cleanly on linux-next. But compilation reports undefined function pcpu_alloc_alloc_info() in both contig.c and discontig.c. arch/ia64/mm/contig.c: In function 'setup_per_cpu_areas': arch/ia64/mm/contig.c:208: error: implicit declaration of function 'pcpu_alloc_al loc_info' arch/ia64/mm/contig.c:208: warning: assignment makes pointer from integer without a cast arch/ia64/mm/contig.c:211: error: dereferencing pointer to incomplete type arch/ia64/mm/contig.c:225: error: dereferencing pointer to incomplete type arch/ia64/mm/contig.c:226: error: dereferencing pointer to incomplete type arch/ia64/mm/contig.c:227: error: dereferencing pointer to incomplete type arch/ia64/mm/contig.c:228: error: dereferencing pointer to incomplete type arch/ia64/mm/contig.c:229: error: dereferencing pointer to incomplete type arch/ia64/mm/contig.c:230: error: dereferencing pointer to incomplete type arch/ia64/mm/contig.c:236: error: dereferencing pointer to incomplete type arch/ia64/mm/contig.c:237: error: dereferencing pointer to incomplete type arch/ia64/mm/contig.c:237: error: dereferencing pointer to incomplete type arch/ia64/mm/contig.c:238: error: dereferencing pointer to incomplete type arch/ia64/mm/contig.c:239: error: dereferencing pointer to incomplete type arch/ia64/mm/contig.c:240: error: dereferencing pointer to incomplete type arch/ia64/mm/contig.c:244: error: dereferencing pointer to incomplete type arch/ia64/mm/contig.c:244: error: dereferencing pointer to incomplete type arch/ia64/mm/contig.c:245: error: dereferencing pointer to incomplete type arch/ia64/mm/contig.c:246: error: dereferencing pointer to incomplete type arch/ia64/mm/contig.c:247: error: dereferencing pointer to incomplete type arch/ia64/mm/contig.c:250: warning: passing argument 1 of 'pcpu_setup_first_chunk ' makes integer from pointer without a cast arch/ia64/mm/contig.c:250: warning: passing argument 2 of 'pcpu_setup_first_chunk ' makes integer from pointer without a cast arch/ia64/mm/contig.c:250: error: too few arguments to function 'pcpu_setup_first _chunk' arch/ia64/mm/contig.c:254: error: implicit declaration of function 'pcpu_free_all oc_info' -- To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
![]() |