On Thu, May 14, 2009 at 08:17:51AM -0700, David Woodhouse wrote: > On Wed, 2009-05-13 at 16:13 -0700, Fenghua Yu wrote: > > Compiling kernel on IA64 reports two warnings in intel-iommu.c: > > > > drivers/pci/intel-iommu.c:3150: warning: format ?%llx? expects > > type ?long long unsigned int?, but argument 4 has type ?u64? > > drivers/pci/intel-iommu.c: In function ?intel_iommu_map_range?: > > drivers/pci/intel-iommu.c:3201: warning: format ?%llx? expects > > type ?long long unsigned int?, but argument 4 has type ?u64? > > Charset corruption there? I'm sure GCC didn't actually use question > marks... Yes, somehow the charset is corrupted during procedure. Below is correct one: drivers/pci/intel-iommu.c: In function ‘intel_iommu_attach_device’: drivers/pci/intel-iommu.c:3150: warning: format ‘%llx’ expects type ‘long long unsigned int’, but argument 4 has type ‘u64’ drivers/pci/intel-iommu.c: In function ‘intel_iommu_map_range’: drivers/pci/intel-iommu.c:3201: warning: format ‘%llx’ expects type ‘long long unsigned int’, but argument 4 has type ‘u64’ > > Perhaps this would be better, modelled after commit fe333321: > > diff --git a/arch/ia64/include/asm/types.h b/arch/ia64/include/asm/types.h > index e36b371..b0ecc20 100644 > --- a/arch/ia64/include/asm/types.h > +++ b/arch/ia64/include/asm/types.h > @@ -13,7 +13,11 @@ > * David Mosberger-Tang <davidm@xxxxxxxxxx>, Hewlett-Packard Co > */ > > +#ifdef __KERNEL__ > +#include <asm-generic/int-ll64.h> > +#else > #include <asm-generic/int-l64.h> > +#endif > > #ifdef __ASSEMBLY__ > # define __IA64_UL(x) (x) > A lot of places in IA64 kernel assume l64. So it would be a big patch and testing to change to ll64. I assume Matthew's patch will do that? Thanks. -Fenghua -- To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|