On Thu, May 07, 2009 at 01:35:43PM +0900, FUJITA Tomonori wrote: > We unified x86 and IA64's handling of multiple dma mapping operations > (struct dma_map_ops in linux/dma-mapping.h) so we can remove > duplication in their arch/include/asm/dma-mapping.h. > > This patchset adds include/asm-generic/dma-mapping.h that provides > some generic dma mapping function definitions for the users of struct > dma_map_ops. This enables us to remove about 100 lines. This also > enables us to easily add CONFIG_DMA_API_DEBUG support, which only x86 > supports for now. The 4th patch adds CONFIG_DMA_API_DEBUG support to > IA64 by adding only 8 lines. > > This is against tip/master since tip has some changes to > arch/x86/include/asm/dma-mapping.h. > > = > arch/ia64/Kconfig | 1 + > arch/ia64/include/asm/dma-mapping.h | 110 ++------------------ > arch/x86/Kconfig | 1 + > arch/x86/include/asm/dma-mapping.h | 174 +------------------------------- > include/asm-generic/dma-mapping.h | 190 +++++++++++++++++++++++++++++++++++ > lib/dma-debug.c | 82 +++++++++------ > 6 files changed, 252 insertions(+), 306 deletions(-) Patchset looks good to me. As a follow-up work we should try to unify the *_coherent functions too. Acked-by: Joerg Roedel <joerg.roedel@xxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
![]() |