Re: [PATCH 01/35] x86: clean up speedctep-centrino and reduce cpumask_t usage
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Mike Travis <travis@xxxxxxx>
- Subject: Re: [PATCH 01/35] x86: clean up speedctep-centrino and reduce cpumask_t usage
- From: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
- Date: Tue, 21 Oct 2008 11:09:25 +1100
- Cc: Ingo Molnar <mingo@xxxxxxx>, Rusty Russell <rusty@xxxxxxxxxxxxxxx>, davej@xxxxxxxxxxxxxxxxx, Jeremy Fitzhardinge <jeremy@xxxxxxxx>, Jes Sorensen <jes@xxxxxxx>, IA64 <linux-ia64@xxxxxxxxxxxxxxx>, S390 <linux-s390@xxxxxxxxxxxxxxx>, peterz@xxxxxxxxxxxxx, Jack Steiner <steiner@xxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Eric Dumazet <dada1@xxxxxxxxxxxxx>, PowerPC <linuxppc-dev@xxxxxxxxxx>, Andi Kleen <andi@xxxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Yinghai Lu <yhlu.kernel@xxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, SPARC <sparclinux@xxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, David Miller <davem@xxxxxxxxxxxxx>
- In-reply-to: <20081020170319.730428000@xxxxxxxxxxxxxxxxxxxxxxxxxx>
- List-id: <linux-ia64.vger.kernel.org>
- References: <20081020170319.539427000@xxxxxxxxxxxxxxxxxxxxxxxxxx> <20081020170319.730428000@xxxxxxxxxxxxxxxxxxxxxxxxxx>
Hi Mike,
Just a first small thing:
On Mon, 20 Oct 2008 10:03:20 -0700 Mike Travis <travis@xxxxxxx> wrote:
>
> 1) The #ifdef CONFIG_HOTPLUG_CPU seems unnecessary these days.
> 2) The loop can simply skip over offline cpus, rather than creating a tmp mask.
> 3) set_mask is set to either a single cpu or all online cpus in a policy.
> Since it's just used for set_cpus_allowed(), any offline cpus in a policy
> don't matter, so we can just use cpumask_of_cpu() or the policy->cpus.
>
> From: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> Signed-off-by: Mike Travis <travis@xxxxxxx>
The From: line should be the first nonempty line in the mail to get the
attribution correct.
--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/
Attachment:
pgplUzphjmckc.pgp
Description: PGP signature
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]