RE: [PATCH 1/2]Add Variable Page Size and IA64 Support in Intel IOMMU: Generic Part
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Bjorn Helgaas <bjorn.helgaas@xxxxxx>
- Subject: RE: [PATCH 1/2]Add Variable Page Size and IA64 Support in Intel IOMMU: Generic Part
- From: "Yu, Fenghua" <fenghua.yu@xxxxxxxxx>
- Date: Fri, 3 Oct 2008 17:21:36 -0700
- Accept-language: en-US
- Acceptlanguage: en-US
- Cc: "Luck, Tony" <tony.luck@xxxxxxxxx>, Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>, David Woodhouse <dwmw2@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>, Avi Kivity <avi@xxxxxxxxxx>, Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, "linux-ia64@xxxxxxxxxxxxxxx" <linux-ia64@xxxxxxxxxxxxxxx>
- In-reply-to: <200810030933.10627.bjorn.helgaas@xxxxxx>
- List-id: <linux-ia64.vger.kernel.org>
- References: <BAE9DCEF64577A439B3A37F36F9B691C0339372B@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <200810020931.48952.bjorn.helgaas@xxxxxx> <A6AD88C3F2289247BE726C37303E1EB88408ADFF@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <200810030933.10627.bjorn.helgaas@xxxxxx>
- Thread-index: AcklbV5MAZpOn9dVQ12fpl9B/z8RpQASNXHw
- Thread-topic: [PATCH 1/2]Add Variable Page Size and IA64 Support in Intel IOMMU: Generic Part
>> >> The current Intel IOMMU code assumes that both host page size and Intel IOMMU page size are 4K. The first patch supports variable page size. This provides support for IA64 which has multiple page sizes.
>> >>
> >> This patch also adds some other code hooks for IA64 platform including DMAR_OPERATION_TIMEOUT definition, .
>>
>> >Can you split this patch up? It contains several logically separate
>> changes:
>> > - casting things to unsigned long long
>> > - adding stuff under #ifdef CONFIG_IA64
>> > - page size changes
>> > - whitespace changes
>>
>> Depends on who is picking up the generic patch. If it's needed, I can >split it into multiple patches.
>Regardless of who's picking up the patch, splitting it makes it
>easier to review and easier to spot bugs, and makes bisection yield
>better information.
Since more than 95% of code in the patch is directly related to page size changes, splitting the patch will generate one big patch (95% of current patch size) and a few small patches. I would like to still send one single updated patch based on collected comments.
Thanks.
-Fenghua
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]