salinfo_work_to_do() intentionally ignores the return value of down_trylock() and calls up() regardless of if the lock was taken or not. This patch suppresses the warning generated by ignoring this return value - down_trylock() is annotated with __must_check. (void)down_trylock() was not sufficient. arch/ia64/kernel/salinfo.c: In function `salinfo_work_to_do': arch/ia64/kernel/salinfo.c:195: warning: ignoring return value of `down_trylock' # ia64-unknown-linux-gnu-gcc --version ia64-unknown-linux-gnu-gcc (GCC) 3.4.5 Copyright (C) 2004 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx> Index: linux-2.6/arch/ia64/kernel/salinfo.c =================================================================== --- linux-2.6.orig/arch/ia64/kernel/salinfo.c 2008-08-03 09:52:08.000000000 +1000 +++ linux-2.6/arch/ia64/kernel/salinfo.c 2008-08-03 10:03:36.000000000 +1000 @@ -192,7 +192,7 @@ struct salinfo_platform_oemdata_parms { static void salinfo_work_to_do(struct salinfo_data *data) { - down_trylock(&data->mutex); + if (down_trylock(&data->mutex)) { ; }; /* Ignore return value */ up(&data->mutex); } -- To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
![]() |