After recent changes setting elfcorehdr_addr to ELFCORE_ADDR_MAX
will cause is_kdump_kernel() to return 0 when it should return 1.
Instead use vmcore_unusable(), which has been added for this purpose.
Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>
---
Andrew, this can wait until post 2.6.27 as although the current
state of affairs is confusing, a bug does not manifest at this time
as there are no callers of is_kdump_kernel on ia64 at this time.
is_vmcore_usable() and vmcore_unusable() are provided by a previous
patch in this series
Index: linux-2.6/arch/ia64/kernel/setup.c
===================================================================
--- linux-2.6.orig/arch/ia64/kernel/setup.c 2008-07-31 09:41:15.000000000 +1000
+++ linux-2.6/arch/ia64/kernel/setup.c 2008-07-31 09:41:36.000000000 +1000
@@ -509,11 +509,11 @@ int __init reserve_elfcorehdr(unsigned l
* to work properly.
*/
- if (elfcorehdr_addr >= ELFCORE_ADDR_MAX)
+ if (!is_vmcore_usable())
return -EINVAL;
if ((length = vmcore_find_descriptor_size(elfcorehdr_addr)) == 0) {
- elfcorehdr_addr = ELFCORE_ADDR_MAX;
+ vmcore_unusable();
return -EINVAL;
}
--
--
Horms
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
|