Re: [PATCH 5/5] sh: Define elfcorehdr_addr in arch dependent section
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Vivek Goyal <vgoyal@xxxxxxxxxx>
- Subject: Re: [PATCH 5/5] sh: Define elfcorehdr_addr in arch dependent section
- From: Paul Mundt <lethal@xxxxxxxxxxxx>
- Date: Tue, 29 Jul 2008 23:18:35 +0900
- Cc: Simon Horman <horms@xxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Muli Ben-Yehuda <muli@xxxxxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>, linux-ia64@xxxxxxxxxxxxxxx, Chandru <chandru@xxxxxxxxxx>, kexec@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Terry Loftin <terry.loftin@xxxxxx>, "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Paul Mackerras <paulus@xxxxxxxxx>, linuxppc-dev@xxxxxxxxxx
- In-reply-to: <20080728211514.GE9985@xxxxxxxxxx>
- List-id: <linux-ia64.vger.kernel.org>
- Mail-followup-to: Paul Mundt <lethal@xxxxxxxxxxxx>, Vivek Goyal <vgoyal@xxxxxxxxxx>, Simon Horman <horms@xxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Muli Ben-Yehuda <muli@xxxxxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>, linux-ia64@xxxxxxxxxxxxxxx, Chandru <chandru@xxxxxxxxxx>, kexec@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Terry Loftin <terry.loftin@xxxxxx>, "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Paul Mackerras <paulus@xxxxxxxxx>, linuxppc-dev@xxxxxxxxxx
- References: <20080727234529.GM6175@xxxxxxxxxxxx> <20080728015117.GA12055@xxxxxxxxxxxx> <20080728024526.GB3334@xxxxxxxxxxxx> <20080728034007.GA30450@xxxxxxxxxxxx> <20080728211025.GA9985@xxxxxxxxxx> <20080728211156.GB9985@xxxxxxxxxx> <20080728211314.GC9985@xxxxxxxxxx> <20080728211408.GD9985@xxxxxxxxxx> <20080728211514.GE9985@xxxxxxxxxx>
- User-agent: Mutt/1.5.13 (2006-08-11)
On Mon, Jul 28, 2008 at 05:15:14PM -0400, Vivek Goyal wrote:
> o Move elfcorehdr_addr definition in arch dependent crash dump file. This is
> equivalent to defining elfcorehdr_addr under CONFIG_CRASH_DUMP instead of
> CONFIG_PROC_VMCORE. This is needed by is_kdump_kernel() which can be
> used irrespective of the fact whether CONFIG_PROC_VMCORE is enabled or
> not.
>
> o I don't see sh setup code parsing the command line for elfcorehdr_addr. I
> am wondering how does vmcore interface work on sh. Anyway, I am atleast
> defining elfcoredhr_addr so that compilation is not broken on sh.
>
Hmm, you are correct, it seems like it was either lost in a merge
somewhere or I simply neglected to check it in it when I was testing this
stuff initially. Thanks for noticing!
> Signed-off-by: Vivek Goyal <vgoyal@xxxxxxxxxx>
Acked-by: Paul Mundt <lethal@xxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]