Aesthetic issues aside is it safe to call up() if down_trylock() failed? arch/ia64/kernel/salinfo.c: In function `salinfo_work_to_do': arch/ia64/kernel/salinfo.c:195: warning: ignoring return value of `down_trylock' Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx> Index: linux-2.6/arch/ia64/kernel/salinfo.c =================================================================== --- linux-2.6.orig/arch/ia64/kernel/salinfo.c 2008-07-29 19:06:33.000000000 +1000 +++ linux-2.6/arch/ia64/kernel/salinfo.c 2008-07-29 19:40:02.000000000 +1000 @@ -192,8 +192,8 @@ struct salinfo_platform_oemdata_parms { static void salinfo_work_to_do(struct salinfo_data *data) { - down_trylock(&data->mutex); - up(&data->mutex); + if (down_trylock(&data->mutex) == 0) + up(&data->mutex); } static void -- To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
![]() |