>> +#define is_kernel_addr(x) \ >> + ((PAGE_OFFSET <= (x) && \ >> + (x) < (PAGE_OFFSET + (1UL << IA64_MAX_PHYS_BITS))) || \ >> + (KERNEL_START <= (x) && \ >> + (x) < KERNEL_START + KERNEL_TR_PAGE_SIZE)) >> >> Misleading name. What does it consider a "kernel_addr"? Just >> region 7 (up to physical address limit) and the piece of region >> 5 that is mapped by itr[0]/dtr[0]. Preferebly pick a better name >> or add a comment here saying what this is testing for. > > How about xencomm_is_phys_contiguous()? > Renaming it requires patches to drivers/xen/xencomm.c. > If okay, I'll also send the patch to common files. That sounds a bit more meaningful ... except that such a function would also require a "size" (or "end") parameter. It makes no sense to ask whether a solitary address is contiguous. -Tony -- To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|