On Fri, May 09, 2008 at 02:03:19PM -0700, Christoph Lameter wrote: > On Fri, 9 May 2008, Russ Anderson wrote: > > > + local_irq_save(irq_flags); > > The page migration functions expect to be called in non atomic contexts > since they use things like lock_page(). Can you just drop the irq disable? Yes. > The spinlock should not be there either. Page migration serialize via > the LRU. Pages that are to be migrated have to be taken off the LRU > first. There is no danger of two threads trying to migrate the same > page because the second one will not be able to take it off the LRU > anymore. -- Russ Anderson, OS RAS/Partitioning Project Lead SGI - Silicon Graphics Inc rja@xxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|