RE: [04/17] [PATCH] Add kvm arch-specific core code for kvm/ia64.-V8
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: <carsteno@xxxxxxxxxx>
- Subject: RE: [04/17] [PATCH] Add kvm arch-specific core code for kvm/ia64.-V8
- From: "Zhang, Xiantao" <xiantao.zhang@xxxxxxxxx>
- Date: Tue, 1 Apr 2008 19:05:36 +0800
- Cc: "Avi Kivity" <avi@xxxxxxxxxxxx>, "Luck, Tony" <tony.luck@xxxxxxxxx>, "Xu, Anthony" <anthony.xu@xxxxxxxxx>, "Jes Sorensen" <jes@xxxxxxx>, "Akio Takebe" <takebe_akio@xxxxxxxxxxxxxx>, <kvm-devel@xxxxxxxxxxxxxxxxxxxxx>, <kvm-ia64-devel@xxxxxxxxxxxxxxxxxxxxx>, <linux-ia64@xxxxxxxxxxxxxxx>, <virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx>
- In-reply-to: <47F2159B.5060709@xxxxxxxxxx>
- List-id: <linux-ia64.vger.kernel.org>
- References: <42DFA526FC41B1429CE7279EF83C6BDC01048245@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <47F0FAA5.2090109@xxxxxxxxxx> <42DFA526FC41B1429CE7279EF83C6BDC01048488@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <47F1E9F8.6010801@xxxxxxxxxx> <42DFA526FC41B1429CE7279EF83C6BDC0104870C@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <47F2159B.5060709@xxxxxxxxxx>
- Thread-index: AciT6AcqgqvFBrXuRVuxVRZJgp89KwAACkDw
- Thread-topic: [04/17] [PATCH] Add kvm arch-specific core code for kvm/ia64.-V8
Carsten Otte wrote:
> Zhang, Xiantao wrote:
>> Carsten Otte wrote:
>>> Zhang, Xiantao wrote:
>>>> Hi, Carsten
>>>> Why do you think it is racy? In this function,
>>>> target_vcpu->arch.launched should be set to 1 for the first run,
>>>> and keep its value all the time. Except the first IPI to wake up
>>>> the vcpu, all IPIs received by target vcpu should go into "else"
>>>> condition. So you mean the race condition exist in "else" code ?
>>> For example to lock against destroying that vcpu. Or, the waitqueue
>>> may become active after if (waitqueue_active()) and before
>>> wake_up_interruptible(). In that case, the target vcpu might sleep
>>> and not get waken up by the ipi.
>> I don't think it may cause issue, because the target vcpu at least
>> can be waken up by the timer interrupt.
>>
>> But as you said, x86 side also have the same race issue ?
> As far as I can tell, x86 does'nt have that race.
Hi, Carsten
I can't understand why it only exist at IA64 side. Thank you!
Xiantao
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]