Re: [01/17]PATCH Add API for allocating dynamic TR resouce. V8
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: "Zhang, Xiantao" <xiantao.zhang@xxxxxxxxx>
- Subject: Re: [01/17]PATCH Add API for allocating dynamic TR resouce. V8
- From: Jes Sorensen <jes@xxxxxxx>
- Date: Mon, 31 Mar 2008 11:03:45 +0200
- Cc: Avi Kivity <avi@xxxxxxxxxxxx>, "Luck, Tony" <tony.luck@xxxxxxxxx>, "Xu, Anthony" <anthony.xu@xxxxxxxxx>, Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>, kvm-devel@xxxxxxxxxxxxxxxxxxxxx, kvm-ia64-devel@xxxxxxxxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, Carsten Otte <cotte@xxxxxxxxxx>
- In-reply-to: <42DFA526FC41B1429CE7279EF83C6BDC0104823F@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
- List-id: <linux-ia64.vger.kernel.org>
- References: <42DFA526FC41B1429CE7279EF83C6BDC0104823F@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
- User-agent: Thunderbird 2.0.0.12 (X11/20080226)
Hi Xiantao,
I general I think the code in this patch is fine. I have a couple of
nit-picking comments:
+ if (target_mask&0x1) {
The formatting here isn't quite what most of the kernel does. It would
be better if you added spaces so it's a little easier to read, ie:
if (target_mask & 0x1) {
+ p = &__per_cpu_idtrs[cpu][0][0];
+ for (i = IA64_TR_ALLOC_BASE; i <= per_cpu(ia64_tr_used,
cpu);
+ i++,
p++) {
+ if (p->pte&0x1)
Same thing here.
+#define RR_TO_RID(rr) ((rr)<<32>>40)
I would prefer to have this one defined like this:
#define RR_TO_RID(rr) (rr >> 8) & 0xffffff
It should generate the same code, but is more intuitive for the reader.
Otherwise I think this patch is fine - this is really just cosmetics.
Cheers,
Jes
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]