tgingold@xxxxxxx wrote: > Hi, > > Selon "Zhang, Xiantao" <xiantao.zhang@xxxxxxxxx>: > >>> From 5f82ea88c095cf89cbae920944c05e578f35365f Mon Sep 17 00:00:00 >>> 2001 >> From: Xiantao Zhang <xiantao.zhang@xxxxxxxxx> >> Date: Wed, 12 Mar 2008 14:48:09 +0800 >> Subject: [PATCH] kvm/ia64: Add mmio decoder for kvm/ia64. [...] >> + post_update = (inst.M5.i << 7) + inst.M5.imm7; >> + if (inst.M5.s) >> + temp -= post_update; >> + else >> + temp += post_update; > > The sign extension is not done correctly here. (This has been fixed > in Xen code). Include the fix in the latest merge candidate patchset. Thanks! :) git://git.kernel.org/pub/scm/linux/kernel/git/xiantao/kvm-ia64.git kvm-ia64-mc8 > >> + post_update = (inst.M3.i << 7) + inst.M3.imm7; >> + if (inst.M3.s) >> + temp -= post_update; >> + else >> + temp += post_update; > > Ditto. > >> + post_update = (inst.M10.i << 7) + inst.M10.imm7; + if >> (inst.M10.s) + temp -= post_update; >> + else >> + temp += post_update; > > Ditto. > >> + post_update = (inst.M10.i << 7) + inst.M10.imm7; + if >> (inst.M10.s) + temp -= post_update; >> + else >> + temp += post_update; > > Ditto. > >> + post_update = (inst.M15.i << 7) + inst.M15.imm7; + if >> (inst.M15.s) + temp -= post_update; >> + else >> + temp += post_update; > > Ditto. > > Tristan. -- To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|