Re: [PATCH 6/8] ptrace: arch_ptrace -ENOSYS return
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
- Subject: Re: [PATCH 6/8] ptrace: arch_ptrace -ENOSYS return
- From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
- Date: Thu, 20 Mar 2008 03:40:05 -0400
- Cc: Roland McGrath <roland@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, Ingo Molnar <mingo@xxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, David Miller <davem@xxxxxxxxxxxxx>, sparclinux@xxxxxxxxxxxxxxx, Paul Mackerras <paulus@xxxxxxxxx>, linuxppc-dev@xxxxxxxxxx, Richard Henderson <rth@xxxxxxxxxxx>, tony.luck@xxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx
- In-reply-to: <alpine.LFD.1.00.0803191935080.3020@xxxxxxxxxxxxxxxxxxxxxxxxxx>
- List-id: <linux-ia64.vger.kernel.org>
- References: <20080319211714.8B14226F995@xxxxxxxxxxxxxxxxxxx> <20080319212024.EA03126F995@xxxxxxxxxxxxxxxxxxx> <alpine.LFD.1.00.0803191935080.3020@xxxxxxxxxxxxxxxxxxxxxxxxxx>
- User-agent: Mutt/1.5.17 (2007-11-01)
On Wed, Mar 19, 2008 at 07:40:25PM -0700, Linus Torvalds wrote:
>
> And I have to say, I really hate that
>
> ret = arch_ptrace(child, request, addr, data);
> if (ret == -ENOSYS && !forced_successful_syscall_return())
> ret = ptrace_request(child, request, addr, data);
>
> thing. Instead of doing it that ugly way (return value and a special
> per-arch forced_successful_syscall_return() thing), this really smells
> like you just want to change the calling conventions for "arch_ptrace()"
> instead.
>
> Wouldn't it be nicer to just let "arch_ptrace()" return a flag saying
> whether it handled things or not?
I think the easiest and cleanest would be to just drop this whole
series. There's no inherent advantage of
ret = -ENOSYS;
in the arch_ptrace default case over
ret = ptrace_request(...);
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]