* Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: > On Thu, 28 Feb 2008 12:50:41 +0100 Ingo Molnar <mingo@xxxxxxx> wrote: > > > @@ -1000,7 +1001,7 @@ void release_console_sem(void) > > * If we try to wake up klogd while printing with the runqueue lock > > * held, this will deadlock. > > */ > > - if (wake_klogd && !runqueue_is_locked()) > > + if (wake_klogd) > > wake_up_klogd(); > > } > > I don't think we shoudl have added that hack in the first place. It > solves a problem which about three developers hit four times in five > years but it has made kernel logging less reliable for everyone. well, the problem was ia64, not a problem on x86 or other platforms. The problem here is ia64 not setting up percpu data structures soon enough. It has blown up in the past in other areas, and it will likely blow up in the future in other areas as well. It's just not robust to have init dependencies on such basic data structures like percpu areas like that. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|