Re: [PATCH] SGI Altix mmtimer - allow larger number of timers per node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 15, 2008 at 10:54:59PM -0800, Andrew Morton wrote:
> 
> drivers/char/mmtimer.c: In function `sgi_timer_del':
> drivers/char/mmtimer.c:607: warning: 't' might be used uninitialized in this function
> 
> Are you sure this is absolutely always a false positive?   If so,
> we can shut it up with uninitialized_var().

Only 2 ways 't' wouldn't be set at all:
  - If 'n' was NULL right away at line 613.  We then exit immediatly at line 626.

  - If we never found 't->timer == timr', in which case we made it to the end of a branch, and once again 'n' would be NULL and would exit right away at line 626.

So yes, I'm in agreement with your patch to shut it up with uninitialized_var().
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [Sparc Linux]     [DCCP]     [Linux ARM]     [Yosemite News]     [Linux SCSI]     [Linux x86_64]     [Linux for Ham Radio]

  Powered by Linux