On Sat, Feb 16, 2008 at 08:27:06PM -0500, J. Bruce Fields wrote: > > This should have been done in the first place, IMO. Avoid header file > > dependencies, faster compile, avoid crap like the above. > > OK. So as a general rule, we should skip the include any time when a > few structure declarations would suffice? Yes. Unessecary includes should always be avoided, and forward declarations are a nice way to avoid includes. > Hm. It also seems wrong that sys_ia32.c would need to include so many > nfsd/sunrpc headers. It looks like that should be easy to fix with a > better organization of the nfsd headers--I'll do that, assuming it's > considered worthwhile.... Why does it need to include either of these at all? There's nothing nfs-specific in that file. - To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|