Re: x86/non-x86: percpu, node ids, apic ids x86.git fixup
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Mike Travis <travis@xxxxxxx>
- Subject: Re: x86/non-x86: percpu, node ids, apic ids x86.git fixup
- From: Ingo Molnar <mingo@xxxxxxx>
- Date: Wed, 30 Jan 2008 20:30:39 +0100
- Cc: "Luck, Tony" <tony.luck@xxxxxxxxx>, Geert Uytterhoeven <Geert.Uytterhoeven@xxxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Linux Kernel Development <linux-kernel@xxxxxxxxxxxxxxx>, Linux/PPC Development <linuxppc-dev@xxxxxxxxxx>, linux-ia64@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx
- In-reply-to: <47A0CD4B.5040706@xxxxxxx>
- List-id: <linux-ia64.vger.kernel.org>
- References: <200801301414.m0UEEgCC006371@xxxxxxxxxxxxxxx> <Pine.LNX.4.64.0801301622460.11859@xxxxxxxxxxxxxxxx> <47A09F8A.3000309@xxxxxxx> <20080130161036.GA12293@xxxxxxx> <1FE6DD409037234FAB833C420AA843EC757C72@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20080130180623.GA24881@xxxxxxx> <1FE6DD409037234FAB833C420AA843EC757DEA@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <47A0CD4B.5040706@xxxxxxx>
- User-agent: Mutt/1.5.17 (2007-11-01)
* Mike Travis <travis@xxxxxxx> wrote:
> Could this be a problem with:
>
> #ifdef HAVE_MODEL_SMALL_ATTRIBUTE
> # define PER_CPU_ATTRIBUTES __attribute__((__model__ (__small__)))
> #endif
>
> This is only defined for !__ASSEMBLY__
nope, moving that per the patch below did not resolve the link problems.
Ingo
-------------->
Subject: ia64: build fix #3
From: Ingo Molnar <mingo@xxxxxxx>
Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
---
include/asm-ia64/percpu.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
Index: linux-x86.q/include/asm-ia64/percpu.h
===================================================================
--- linux-x86.q.orig/include/asm-ia64/percpu.h
+++ linux-x86.q/include/asm-ia64/percpu.h
@@ -8,6 +8,10 @@
#define PERCPU_ENOUGH_ROOM PERCPU_PAGE_SIZE
+#ifdef HAVE_MODEL_SMALL_ATTRIBUTE
+# define PER_CPU_ATTRIBUTES __attribute__((__model__ (__small__)))
+#endif
+
#ifdef __ASSEMBLY__
# define THIS_CPU(var) (per_cpu__##var) /* use this to mark accesses to per-CPU variables... */
#else /* !__ASSEMBLY__ */
@@ -15,10 +19,6 @@
#include <linux/threads.h>
-#ifdef HAVE_MODEL_SMALL_ATTRIBUTE
-# define PER_CPU_ATTRIBUTES __attribute__((__model__ (__small__)))
-#endif
-
#ifdef CONFIG_SMP
#define __my_cpu_offset __ia64_per_cpu_var(local_per_cpu_offset)
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
- References:
- Re: x86/non-x86: percpu, node ids, apic ids x86.git fixup
- Re: x86/non-x86: percpu, node ids, apic ids x86.git fixup
- Re: x86/non-x86: percpu, node ids, apic ids x86.git fixup
- RE: x86/non-x86: percpu, node ids, apic ids x86.git fixup
- Re: x86/non-x86: percpu, node ids, apic ids x86.git fixup
- RE: x86/non-x86: percpu, node ids, apic ids x86.git fixup
- Re: x86/non-x86: percpu, node ids, apic ids x86.git fixup
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]