Hi Akio,
Thank you for your comments.
Xiantao
Akio Takebe wrote:
> Hi, Xiantao
m: already loaded the other module!\n");
> + r = -EEXIST;
> + goto out;
> + }
> +
> + r = -ENOMEM;
> extra white space.
Yes. One more white space here.
> + kvm_vmm_info = kzalloc(sizeof(struct kvm_vmm_info), GFP_KERNEL);
> + if (!kvm_vmm_info)
> + goto out;
> +
> Can we get the message of shortage of memory by qemu?
The memory allocation here is just for vmm module initialization, and no
qemu/vm created so far.
Memory shortage here, will leads to module insert fail, and this is our
expectable result.
> + if (!vti_cpu_has_kvm_support()) {
> + printk(KERN_ERR "kvm: no hardware support\n");
> + r = -EOPNOTSUPP;
> + goto out_free0;
> + }
> +
> We had better check vti support at the first.
OK, I will move it to first in arch_init. :)
> +}
> kvm_vmm_info = (void *)0?
Maybe NULL is better :)
>
>
------------------------------------------------------------------------
-
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2005.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> kvm-devel mailing list
> kvm-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.sourceforge.net/lists/listinfo/kvm-devel
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
|