Re: [PATCH] iounmap if tioce_kern_init fails in ia64/sn/pci/tioce_provider.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Simon Horman wrote:
> On Sun, Nov 04, 2007 at 12:12:23PM +0100, Roel Kluin wrote:
>> Do iounmap if tioce_kern_init fails
> 
> This is covered by a subsequent patch, right?

aparently it should, what am I missing?

>> Signed-off-by: Roel Kluin <12o3l@xxxxxxxxxx>
>> ---
>> diff --git a/arch/ia64/sn/pci/tioce_provider.c b/arch/ia64/sn/pci/tioce_provider.c
>> index cee9379..128ed07 100644
>> --- a/arch/ia64/sn/pci/tioce_provider.c
>> +++ b/arch/ia64/sn/pci/tioce_provider.c
>> @@ -1008,6 +1008,7 @@ tioce_bus_fixup(struct pcibus_bussoft *prom_bussoft, struct pci_controller *cont
>>  
>>  	tioce_kern = tioce_kern_init(tioce_common);
>>  	if (tioce_kern == NULL) {
>> +		iounmap(tioce_common->ce_pcibus.bs_base);
>>  		kfree(tioce_common);
>>  		return NULL;
>>  	}


-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [Sparc Linux]     [DCCP]     [Linux ARM]     [Yosemite News]     [Linux SCSI]     [Linux x86_64]     [Linux for Ham Radio]

  Powered by Linux