On Fri, 2007-08-31 at 09:45, Luck, Tony wrote: > > Please consider the scenario when many cpus are calling > > ia64_global_tlb_purge at the same time without any lock. > > Using global variables to indicate tlb flush start and end is not safe > > here. > > Isn't everything protected by the > > spin_lock(&ptcg_lock); > ... > spin_unlock(&ptcg_lock); > > in ia64_global_tlb_purge()? Though the comment that this lock > is required for HW serialization would need to be updated to > note that the s/w implementation also requires this serialization. > > -Tony Ah Yes, I missed this line when reading the patch... So my comments would be 1. avoid declare global variables and functions in .c file. 2. use more precise name for global variable.to e.g ia64_global_tlb_flush_start is better than flush_start. 3. do not use asm in .c file, use intrins instead. Thanks Zou Nan hai - To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|