RE: [PATCH] disable irq's and check need_resched before safe_halt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Yeah, I think the TIF flag was the key in fixing the resched IPI
> notification.  The change in default_idle() is an optimization.
>
> I'm horrified to see the same code coming back: doing interrupt
> enable/disable in the most inner while loop.  Disable interrupt is
> just crude, but I suppose that's the only way to resolve the race
> condition?  Looking at other arch like x86_64, it is also doing the
> same thing.

Yup.  x86 does pretty much the same thing.

I had the perf. team run the problem benchmarks (netperf and volanomark)
with this patch applied ... and they saw no performance difference.

The patch is bundled to go in with the next batch that I send
to Linus.

-Tony
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [Sparc Linux]     [DCCP]     [Linux ARM]     [Yosemite News]     [Linux SCSI]     [Linux x86_64]     [Linux for Ham Radio]

  Powered by Linux