> > Oops. You moved the multiply by sizeof(struct ia64_mca_cpu) up into > > the mca_bootmem() function to make it very specific to this use. But > > mutiply has higher precedence than addition. > > Oh crap - good catch. > Shall I resubmit a corrected patch? Are there any other ways that we might tag the callsite to let modpost know that this instance is safe? Adding a call to a wrapper function in __init_refok space feels kludgy, and whatever comments you stick on that function, it is sitting there waiting for someone who shouldn't to make a call. If not ... then just make the mca_bootmem() function take no args. It can calculate the amount of memory, it can do the next bit too and return a result KERNEL_STACK_SIZE aligned too. -Tony - To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
![]() |