> Here is a patch to do that. We use this internally, but > I had forgotten to post it. Terry, Just got to applying some older patches ... perhaps this one has been sitting too long because I had some apply & build problems with it. Building with arch/ia64/configs/zx1_defconfig and with this patch hand applied I get: LD .tmp_vmlinux1 arch/ia64/hp/common/built-in.o(.init.text+0xcc2): In function `sba_init': : undefined reference to `swiotlb_late_init_with_default_size' arch/ia64/hp/common/built-in.o(.init.text+0xd02): In function `sba_init': : undefined reference to `machvec_init' make: *** [.tmp_vmlinux1] Error 1 sba_init() uses these routines inside #ifdef CONFIG_I64_GENERIC, perhaps you need to do the same? Other issues: 1) No "Signed-off-by" 2) +#include <linux/crash_dump.h> We usually group all the <linux/*> includes together before the <asm/*> ones 3) +extern int swiotlb_late_init_with_default_size (size_t size); extern declarations in ".c" files are frowned upon. This should be in a header file, which should be included (though I see that this guideline has already been ignored as you were just moving the declaration). -Tony - To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
![]() |