On Tue, Jun 26, 2007 at 11:48:50AM +1000, Michael Ellerman wrote: > Currently jprobe.entry is a kprobe_opcode_t *, but that's a lie. On some > platforms it doesn't point to an opcode at all, it points to a function > descriptor. > > It's really a pointer to something that the arch code can turn into a > function entry point. And that's what actually happens, none of the > generic code ever looks at jprobe.entry, it's only ever dereferenced > by arch code. > > So just make it a void *. > > Signed-off-by: Michael Ellerman <michael@xxxxxxxxxxxxxx> Tested on powerpc. Ack to all three patches plus Andrew's declaration fixup. Thanks Michael for the patches. Acked-by: Ananth N Mavinakayanahalli <ananth@xxxxxxxxxx> > --- > > It isn't obvious where kprobes patches should go, is anyone "the" maintainer? > Instead I've just sent this to everyone who'd touched the code lately, or > might be otherwise interested. > > > include/linux/kprobes.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/linux/kprobes.h b/include/linux/kprobes.h > index 23adf60..f4e53b7 100644 > --- a/include/linux/kprobes.h > +++ b/include/linux/kprobes.h > @@ -116,7 +116,7 @@ struct kprobe { > */ > struct jprobe { > struct kprobe kp; > - kprobe_opcode_t *entry; /* probe handling code to jump to */ > + void *entry; /* probe handling code to jump to */ > }; > > DECLARE_PER_CPU(struct kprobe *, current_kprobe); > -- > 1.5.1.3.g7a33b - To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
![]() |