Re: Fix section conflict of ia64_mlogbuf_finish

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>> I suspect EXPORT is left over from the initial development/debug.

Yes, that's right.

The reason why the EXPORT was there is that I supposed a optional use
of ia64_mlogbuf_finish expecting that there would be some non-standard
mca recovery module, module relating kdump or something.
However such module is not there at the moment.

Thanks,
H.Seto

Martin Michlmayr wrote:
* Russ Anderson <rja@xxxxxxx> [2007-05-15 13:32]:
I suspect EXPORT is left over from the initial development/debug.
Either change is fine with me.

OK, then let's use this one instead:


Subject: Fix section conflict of ia64_mlogbuf_finish

Building with GCC 4.2, I get the following error:

  CC      arch/ia64/kernel/mca.o
arch/ia64/kernel/mca.c:275: error: __ksymtab_ia64_mlogbuf_finish causes a
section type conflict

This is because ia64_mlogbuf_finish is both declared static and exported.

Signed-off-by: Martin Michlmayr <tbm@xxxxxxxxxx>

--- a/arch/ia64/kernel/mca.c
+++ b/arch/ia64/kernel/mca.c
@@ -272,7 +272,6 @@ static void ia64_mlogbuf_finish(int wait)
mlogbuf_finished = 1;
 }
-EXPORT_SYMBOL(ia64_mlogbuf_finish);
/*
  * Print buffered messages from INIT context.

-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [Sparc Linux]     [DCCP]     [Linux ARM]     [Yosemite News]     [Linux SCSI]     [Linux x86_64]     [Linux for Ham Radio]

  Powered by Linux