On Tue, Mar 20, 2007 at 01:53:51PM +1100, Keith Owens wrote: > Horms (on Tue, 20 Mar 2007 11:34:28 +0900) wrote: > >On Mon, Mar 19, 2007 at 07:12:44PM -0700, Jay Lan wrote: > >> Since DIE_INIT_SLAVE_ENTER is a non-zero value, thus "nd->sos->rv_rc > >> ==1" is always evaluated. The kdump kernel aborted because nd->sos > >> is NULL in (at least some) MCA cases. > > > >I think that your fix below does correct a problem, > >in that "|| DIE_INIT_SLAVE_ENTER" appears to be quite bogus. > >But if you are worried about nd->sos being NULL, is it worth checking > >for that explicitly. Or will it always be non-NULL with the code below? > > nd->sos is only (and always) defined for the MCA/INIT SAL to OS > handlers. nd->sos is NULL for events such as MCA rendezvous interrupt, > since that event runs on the normal kernel stack. Thanks for the clarification. In that case. Acked-by: Simon Horman <horms@xxxxxxxxxxxx> -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/ - To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|