On 2/2/07, Magnus Damm <magnus.damm@xxxxxxxxx> wrote:
On 2/2/07, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> Magnus Damm <magnus@xxxxxxxxxxxxx> wrote:
>
> > kexec: Fix CONFIG_SMP=n compilation (ia64)
> >
> > This patch makes it possible to compile kexec for ia64 without SMP support.
> > --- 0002/arch/ia64/kernel/machine_kexec.c
> > +++ work/arch/ia64/kernel/machine_kexec.c 2007-02-01 12:35:46.000000000 +0900
> > @@ -70,12 +70,14 @@ void machine_kexec_cleanup(struct kimage
> >
> > void machine_shutdown(void)
> > {
> > +#ifdef CONFIG_SMP
> > int cpu;
> >
> > for_each_online_cpu(cpu) {
> > if (cpu != smp_processor_id())
> > cpu_down(cpu);
> > }
> > +#endif
> > kexec_disable_iosapic();
> > }
>
> hm. I suspect this one should have been #ifndef CONFIG_HOTPLUG_CPU?
Re-reading this I assume you mean #ifdef CONFIG_HOTPLUG_CPU. I would be happy to resend a new updated version of the patch, but I wonder if it may be better to fail miserably during the build than fail silently in the case of CONFIG_SMP=y but CONFIG_HOTPLUG_CPU=n. Any ideas? Nan hai, is there any particular reason why the ia64 kexec code builds on top of cpu hotplug instead of smp functions such as smp_send_stop()? Thanks! / magnus - To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|