Re: [patch] Cache error recovery

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Russ Anderson wrote:
@@ -688,11 +690,11 @@ recover_from_processor_error(int platfor
 	 * The cache check and bus check bits have four possible states
 	 *   cc bc
 	 *    0  0	Weird record, not recovered
-	 *    1  0	Cache error, not recovered
+	 *    1  0	Cache error, attempt recovered
 	 *    0  1	I/O error, attempt recovery
 	 *    1  1	Memory error, attempt recovery
 	 */

Which is right, attempt-"recovered" or "recovery"?

-	if (psp->bc == 0 || pbci == NULL)
+	if (psp->cc == 0 && (psp->bc == 0 || pbci == NULL))
 		return fatal_mca("No bus check");

The message should be replaced by more appropriate one...
"No recoverable check" or just "Weird record"?

And also there are some comments need to be fixed since this
patch makes it incorrect, ex.

>         /*
>          * Well, here is only one bus error.
>          */

Thanks,
H.Seto

-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [Sparc Linux]     [DCCP]     [Linux ARM]     [Yosemite News]     [Linux SCSI]     [Linux x86_64]     [Linux for Ham Radio]

  Powered by Linux