> > Is it better to move above definitions to file include/asm-ia64/pal.h? > > > I'm trying to have the kernel driver as simple as possible and > leave the complexity to application. I agree with Fenghua here ... currently this driver leaves all interpretation of what the values mean to the user application. The interfaces in /sys are a very thin layer to give access to the PAL_MC_ERROR_INJECT call ... so the kernel doesn't need any of this information in asm/pal.h ... if it were just a couple of small structures perhaps I'd let it slide, but there are pages of bit definitions in the SDM, lots more than I'd care to have cluttering up what is already a very busy header file. Besides, putting this information here would just encourage people to include kernel header files in user applications :-) When someone comes up with a better suggestion for where to keep the user side than Documentation/ia64/err_inject.txt, we should definitely split out these structure definitions into an err_inject.h to make it easy for you all to write fabulous injection tools. -Tony - To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|