RE: [PATCH] IA64 trap code 16 bytes atomic copy on montecito

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Keith Owens wrote on Monday, October 30, 2006 10:18 PM
> >+GLOBAL_ENTRY(kprobe_update_inst_bundle)
> >+	alloc loc0=ar.pfs,3,1,0,0
> >+
> >+	and r15=15,r34
> >+	and r14=15,r33
> 
> Use in0, in1, in2, not r32-34.

Also there is no need to resize the register stack frame here, since
this is already a leaf function and there are plenty scratch register
you can use before tap into register stack.  I personally prefer not
to do alloc instruction here.

And I think it would be a lot easier if you implement an intrinsic
function, like ia64_ld16/ia64_st16 and stick them in include/asm-ia64/
gcc_intrin.h and intel_intrin.h.
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [Sparc Linux]     [DCCP]     [Linux ARM]     [Yosemite News]     [Linux SCSI]     [Linux x86_64]     [Linux for Ham Radio]

  Powered by Linux