On Wed, 27 Sep 2006 15:48:32 -0700 Stephane Eranian <eranian@xxxxxxxxxx> wrote: > Andrew, > > Here is the summary of the various point raised by your review and the current > status. I am hoping to close all points by next release. > > ... > > [akpm]: use fget_light() in some place instead of fget() > - not sure understand when to use one versus the other > They are always interchangeable. fget_light() is simply an optimised, messier-to-use version. > > .. > > [akpm]: carta_random32() should be in another header file > - yes, I know. Should I create a specific header file? I don't think random.h > is meant for this. I suppose so. Or just stick the declaration into kernel.h. I had a patch go past the other day which had a hand-rolled fast-but-not-very-good pseudo random number generator in it. I couldn't remember where I'd seen one, and now I can't remember what patch it was that needed it. Sigh. Anyway, a standalone patch which adds that function into lib/whatever.c would be nice. - To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|