Re: [patch] trim output of show_mem()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> This patch goes on top of the patch I posted earlier today. It trims
> the number of lines of memory information output per node down from 5
> lines to one line per node. Kinda helps if you have 1024 live nodes in

That is a great improvement!

> +		printk(KERN_INFO "Node %d:", pgdat->node_id);
...
> +		printk("\tRAM: %ld, reserved: %d, shared: %d, "
> +		       "swap cached: %d\n", present, reserved, shared, cached);

What about making these fixed width fields.

> +		printk(KERN_INFO "Node %4d: ", pgdat->node_id);
...
> +		printk("RAM: %11ld, rsvd: %8d, shrd: %10d, swpd: %10d\n",
> +				present, reserved, shared, cached);

Note, I changed the one tab to a space and abbreviated.  This puts things
into an 80 column display.  How would you feel about putting the two printks
together?

Thanks,
Robin
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [Sparc Linux]     [DCCP]     [Linux ARM]     [Yosemite News]     [Linux SCSI]     [Linux x86_64]     [Linux for Ham Radio]

  Powered by Linux