Dave Hansen writes:
>
[...]
> + */
> +#ifndef __ASSEMBLY__
> +#define ALIGN(x,a) (((x)+(a)-1)&~((a)-1))
This evaluates (a) twice. While in all existing call-sites (a) is
probably a constant, it's still safer to do
#define ALIGN(x,a) ({ typeof(a) __a = (a); (((x) + __a - 1) & ~(__a - 1)); })
in a generic macro and rely on compiler to optimize temporary variable
out.
Nikita.
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
|