Robin Holt wrote: > On Wed, Apr 26, 2006 at 11:12:48AM +0200, Jes Sorensen wrote: >>> - if (status) >>> - printk(KERN_WARNING "smp_call_function failed for " >>> - "uncached_ipi_mc_drain! (%i)\n", status); >>> + (void) smp_call_function(uncached_ipi_mc_drain, NULL, 0, 1); >> This thing could in theory fail so having the error check there seems >> the right thing to me. In either case, please don't (void) the function >> return (this is a style issue, I know). > > I must be blind. Both up and smp cases for smp_call_function appear to > always return 0. What am I missing? Not on all architectures, at least PPC can return != 0 - dunno if this is a realistic case though. If not, maybe the prototype for smp_call_function() ought to be changed. Cheers, Jes - : send the line "unsubscribe linux-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|