RE: Synchronizing Bit operations V2
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: "'Christoph Lameter'" <clameter@xxxxxxx>
- Subject: RE: Synchronizing Bit operations V2
- From: "Chen, Kenneth W" <kenneth.w.chen@xxxxxxxxx>
- Date: Thu, 30 Mar 2006 17:29:56 -0800
- Cc: "Nick Piggin" <nickpiggin@xxxxxxxxxxxx>, "Zoltan Menyhart" <Zoltan.Menyhart@xxxxxxxx>, "Boehm, Hans" <hans.boehm@xxxxxx>, "Grundler, Grant G" <grant.grundler@xxxxxx>, <akpm@xxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <linux-ia64@xxxxxxxxxxxxxxx>
- In-reply-to: <Pine.LNX.4.64.0603301709440.2553@xxxxxxxxxxxxxxxxxxxxxxxxx>
- Thread-index: AcZUYEhkCViVzmVURkezJv7VEOB0fAAAc8cA
Christoph Lameter wrote on Thursday, March 30, 2006 5:13 PM
> Then there will no barrier since clear_bit only has acquire semantics.
> This is a bug in bit operations since smb_mb__before_clear_bit does
> not work as documentted.
Well, please make up your mind with:
Option (1):
#define clear_bit clear_bit_mode(..., RELEASE)
#define Smp_mb__before_clear_bit do { } while (0)
#define Smp_mb__after_clear_bit smp_mb()
Or option (2):
#define clear_bit clear_bit_mode(..., ACQUIRE)
#define Smp_mb__before_clear_bit smp_mb()
#define Smp_mb__after_clear_bit do { } while (0)
I'm fine with either one.
- Ken
-
: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]