On Friday 17 March 2006 09:20, Yasunori Goto wrote: > When CONFIG_NUMA && CONFIG_ARCH_MEMORY_PROBE, nid should be defined > before calling add_memory(nid, start, size). Seems a bit weird to have the node number assignment somewhere hidden in memory hotadd. It would be probably cleaner to have a separate step for this. > +#if defined(CONFIG_NUMA) && defined(CONFIG_ARCH_MEMORY_PROBE) > +extern int arch_nid_probe(u64 start); Instead of adding such ugly ifdefs better just add stubs to all the architectures that support memory hotplug. There are not that many anyways. -Andi > +#else > +static inline int arch_nid_probe(u64 start) > +{ > + return 0; > +} > +#endif > + - : send the line "unsubscribe linux-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
![]() |