Re: [PATCH] Fix percpu interrupt allocation in mmtimer code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>>>>> "Dimitri" == Dimitri Sivanich <sivanich@xxxxxxx> writes:

Dimitri> The timer interrupt in the mmtimer code needs to be allocated
Dimitri> as a percpu interrupt for acceptable performance on larger
Dimitri> systems.

Dimitri> The code needs to be updated to set this up properly, as the
Dimitri> SA_PERCPU_IRQ flag to request_interrupt is not supported.

Dimitri> +EXPORT_SYMBOL(register_percpu_irq);

Hi Dimitri,

EXPORT_SYMBOL_GPL() please.

Dimitri> +static irqreturn_t mmtimer_interrupt(int irq, void *dev_id, struct pt_regs *regs);
Dimitri> +

The prototype needs to go into a header file, it shouldn't be declared
in mmtimer.c. Also please make sure it doesn't exceed the 80 column
limit.

Cheers,
Jes
-
: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [Sparc Linux]     [DCCP]     [Linux ARM]     [Yosemite News]     [Linux SCSI]     [Linux x86_64]     [Linux for Ham Radio]

  Powered by Linux