On Thursday 09 March 2006 09:12, Robin Holt wrote: > On Wed, Mar 08, 2006 at 04:55:45PM -0700, Bjorn Helgaas wrote: > > On Wednesday 08 March 2006 15:02, Dean Roe wrote: > > > Are you saying you *really* want a for_each_sn_cnode() macro? I guess > > > we can go that route if necessary...I just prefer the one-line change > > > rather than changing 4-5 files when we aren't really sure yet what the > > > final implementation will look like. > > > > I saw his response, but it wasn't clear to me what ACPI 3.0 is going > > to solve. Are you saying that with ACPI 3.0, you will be able to > > use for_each_node()? > > The node informatoin is stored in a single byte. With the introduction > of I/O only nodes, we can easily exceed the 512 node limit placed on > the byte size. ACPI 3.0 should raise that node limit to at least a > 16-bit word. I'm only trying to point out that you should be able to separate the for_each_XXX() interface from the current ACPI limit. > > If that's the case, my question is, why can't you use for_each_node() > > today, and use some interim hack to fill in node_possible_map? > > The node field size does not allow for it. Which node field doesn't allow it? for_each_node() uses the node_possible_mask bitmap, which can be any size you need. > > If not, what "for_each_XXX" macro are you planning to use when > > you have ACPI 3.0? > > Not sure yet because ACPI 3.0 is still way off in the future. We > will know more when that time comes. If you think for_each_node() is the correct interface to use here, just use it, and make node_possible_mask large enough. That means you might need some glue code deal with the fact that ACPI 2.0 can't populate the whole thing, but that's not a problem. If you think you need something other than for_each_node(), why not just take a stab at defining the correct interface now, and fix it later if you need to? I think that's better than putting in something that you *know* will need to be changed later. - : send the line "unsubscribe linux-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|