>>-----Original Message----- >>From: Luck, Tony >>Sent: 2006年2月25日 4:25 >>To: Zhang, Yanmin >>Cc: linux-ia64@xxxxxxxxxxxxxxx; Zhang, Yanmin; Pallipadi, Venkatesh; Siddha, Suresh B >>Subject: RE: Export cpu cache info by sysfs >> >>Looks much better. Still a couple of questions: >> >>> Below new patch exports 8 attributes: >>> 1) level >> >>The software developers manual calls the cache levels 1, 2, 3 >>but we report them as 0, 1, 2 (which is compatible with x86 versions >>of these /sys files). Is it better to match the docs, or other >>architecture? We definitely should follow manual. Most chapters of the manual say the cache level from 1, but the detailed explanation of pal call PAL_CACHE_INFO is from 0. I will change it to start from 1. >> >>2) type >>For a combined cache x86 uses the string "Unified", you use >>"Data/Instruction" ... again which is better? "Unified" is better which also matches ia64 manual. I will change it to Unified. Besides, I will delete attribute stride and CONFIG_SYSFS to simplify the patch again. Thanks. - : send the line "unsubscribe linux-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|