I've looked at hugetlb_free_pgd_range() right side up, right side down, up side up, up side down. And it just doesn't look correct to me at all. In that function, we do address transformation before calling free_pgd_range, so the generic function can traverse to right set of page table page. There is no need to do any range check. Signed-off-by: Ken Chen <kenneth.w.chen@xxxxxxxxx> --- ./arch/ia64/mm/hugetlbpage.c.orig 2006-02-23 18:21:28.202422392 -0800 +++ ./arch/ia64/mm/hugetlbpage.c 2006-02-23 18:26:28.256129654 -0800 @@ -125,9 +125,9 @@ void hugetlb_free_pgd_range(struct mmu_g addr = htlbpage_to_page(addr); end = htlbpage_to_page(end); - if (is_hugepage_only_range(tlb->mm, floor, HPAGE_SIZE)) + if (REGION_NUMBER(floor) == RGN_HPAGE) floor = htlbpage_to_page(floor); - if (is_hugepage_only_range(tlb->mm, ceiling, HPAGE_SIZE)) + if (REGION_NUMBER(ceiling) == RGN_HPAGE) ceiling = htlbpage_to_page(ceiling); free_pgd_range(tlb, addr, end, floor, ceiling); - : send the line "unsubscribe linux-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|