Hi Shyam, On Thu, Mar 20, 2025 at 05:12:34PM +0530, Shyam Sundar S K wrote: > On 3/20/2025 16:46, Andi Shyti wrote: > > On Thu, Nov 03, 2022 at 08:11:46PM +0800, Yang Yingliang wrote: > >> irq allocated with devm_request_irq() will be freed in devm_irq_release(), > >> using free_irq() in ->remove() will causes a dangling pointer, and a > >> subsequent double free. So remove the free_irq() in the error path and > >> remove path. > >> > >> Fixes: 969864efae78 ("i2c: amd-mp2: use msix/msi if the hardware supports") > >> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx> > > > > No ack from Ellie and Shyam have come for this patch in almost > > two years. It still applies and it still looks correct to me. > > > > I'm merging it into i2c/i2c-host-fixes in order to have it in > > time for the tests before the pull requests. If Ellie and/or > > Shyam will have concerns, we are still in time to take it off. > > > > Sorry, I missed this. > > Acked-by: Shyam Sundar S K <Shyam-sundar.S-k@xxxxxxx> Thanks, appreciated! I added your ack. Andi